Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Paramchange proposal skips omitempty fields #4403

Merged
merged 11 commits into from
May 28, 2019
Merged

R4R: Paramchange proposal skips omitempty fields #4403

merged 11 commits into from
May 28, 2019

Conversation

mossid
Copy link
Contributor

@mossid mossid commented May 23, 2019 •
edited
Loading

Closes: #4247

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented May 23, 2019 •
edited
Loading

Codecov Report

Merging #4403 into master will increase coverage by 0.06%.
The diff coverage is 77.27%.

@@            Coverage Diff             @@
##           master    #4403      +/-   ##
==========================================
+ Coverage   57.21%   57.27%   +0.06%     
==========================================
  Files         241      242       +1     
  Lines       15123    15149      +26     
==========================================
+ Hits         8653     8677      +24     
- Misses       5840     5841       +1     
- Partials      630      631       +1

fedekunze
fedekunze reviewed May 23, 2019
View reviewed changes
x/gov/endblocker_test.go Outdated Show resolved Hide resolved
x/params/keeper_test.go Outdated Show resolved Hide resolved
x/params/client/cli/tx.go Outdated Show resolved Hide resolved
x/gov/params.go Show resolved Hide resolved
alexanderbez
alexanderbez suggested changes May 23, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor points of feedback, but otherwise LGTM.

x/gov/params.go Show resolved Hide resolved
x/gov/test_common.go Show resolved Hide resolved
mossid and others added 2 commits May 23, 2019 19:56
@mossid @fedekunze
Update x/gov/endblocker_test.go
3497e8b 
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
@mossid
address comments
d68274b
fedekunze
fedekunze approved these changes May 24, 2019
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alexanderbez
alexanderbez approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@alexanderbez
Copy link
Contributor

I realized that simulated tally params are hard-coded and I also added governance param changes to simulation. One of those two things broke CI -- I'm looking into it.

@jackzampolin
Copy link
Member

Looks like CI is fixed here! Are we good to merge?

@alexanderbez alexanderbez merged commit 91e75cb into master May 28, 2019
@alexanderbez alexanderbez deleted the joon/4247-paramchange-json-update-only branch May 28, 2019 00:47
@clevinson clevinson mentioned this pull request Aug 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@fedekunze fedekunze fedekunze approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio Awaiting requested review from alessio

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Paramchange proposal should only contain updated fields
5 participants
@mossid @alexanderbez @jackzampolin @fedekunze @golangcibot